Unverified Commit 4dc1720b authored by Jonathan A. Sternberg's avatar Jonathan A. Sternberg Committed by GitHub
Browse files

fix: do not print the environment when overwriting the environment (#15)

When we print the environment when overwriting the environment, we risk
printing any sensitive information that was held inside of environment
variables. Now that we have determined that this code works, the log
message should be removed to avoid leaking credentials.
parent 60bf96f9
Pipeline #145 failed with stages
in 7 minutes and 26 seconds
......@@ -216,7 +216,6 @@ func (l *Library) build(ctx context.Context, logger *zap.Logger) (string, error)
cmd.Env = removeEnvVar(cmd.Env, "CC")
cmd.Env = removeEnvVar(cmd.Env, "CXX")
cmd.Env = removeEnvVar(cmd.Env, "AR")
logger.Info("Overwrote rust build environment", zap.Strings("env", cmd.Env))
}
logger.Info("Executing cargo build", zap.String("dir", cmd.Dir), zap.String("target", targetString))
if err := cmd.Run(); err != nil {
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment